Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GUI): Stretched Logo on Safari Browser #87

Merged
merged 1 commit into from
Jul 19, 2024
Merged

fix(GUI): Stretched Logo on Safari Browser #87

merged 1 commit into from
Jul 19, 2024

Conversation

nitro56565
Copy link
Contributor

@nitro56565 nitro56565 commented Jul 19, 2024 •
edited by mttrbrts
Loading

Closes #84 #82

Description

This pull request addresses issue #84 , which highlights the problem of the logo appearing stretched on mobile devices and in the Safari browser. The issue was caused by browser-defined CSS, which has now been fixed. The logo will maintain its aspect ratio and display correctly on all devices and browsers, including mobile devices and Safari.

Changes

  • Ensured the logo's dimensions are set to auto to maintain its aspect ratio.
  • Used CSS media queries to adjust the logo size for different screen sizes.
  • Tested and fixed Safari-specific CSS issues.

Screenshots or Video

safari-before
safari-after
safari-mobile-before
safari-mobile-after

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@nitro56565 nitro56565 requested a review from a team as a code owner July 19, 2024 12:53
@netlify Netlify
Copy link

netlify bot commented Jul 19, 2024 •
edited
Loading

✅ Deploy Preview for ap-template-playground ready!

Name Link
🔨 Latest commit 43d5e4c
🔍 Latest deploy log https://app.netlify.com/sites/ap-template-playground/deploys/669a61ae641c4400088860e8
😎 Deploy Preview https://deploy-preview-87--ap-template-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nitro56565
Copy link
Contributor Author

@Vinyl-Davyl rebased and updated

@mttrbrts mttrbrts changed the title Fix(GUI) Stretched Logo on Safari Browser fix(GUI): Stretched Logo on Safari Browser Jul 19, 2024
mttrbrts
mttrbrts approved these changes Jul 19, 2024
View reviewed changes
Copy link
Sponsor Member

@mttrbrts mttrbrts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution, @nitro56565! 🎉

@mttrbrts mttrbrts merged commit 3cf2303 into accordproject:main Jul 19, 2024
7 checks passed
@nitro56565 nitro56565 deleted the nitro56565/i87/safari-logo-bug branch July 19, 2024 13:02
@nitro56565
Copy link
Contributor Author

Thank you @mttrbrts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts mttrbrts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stretched logo on mobile and safari
2 participants
@nitro56565 @mttrbrts